Results 1 to 6 of 6

Thread: bug in gipfeli

  1. #1
    Programmer
    Join Date
    May 2008
    Location
    PL
    Posts
    307
    Thanks
    68
    Thanked 166 Times in 63 Posts

    bug in gipfeli

    In this excerpt one can see that input_block is overridden so prev_block becames pointer to a free memory. It causes crashes on files longer than 64KB especially on Windows.

    Code:
    gipfeli-internal.cc:
    
    string input_block;
    ...
    prev_block = input_block.data();
    input_block = block_reader.GetNextBlock();
    BTW, Reporting issues for gipfeli on GitHub is turned off.

  2. #2
    Member
    Join Date
    Jul 2013
    Location
    United States
    Posts
    194
    Thanks
    44
    Thanked 140 Times in 69 Posts
    Reporting issues may be off, but you can still file pull requests. This sounds like https://github.com/google/gipfeli/pull/4

    Regardless, I don't think gipfeli's author hangs out here… If you find an issue but don't want to actually fix it so you can file a PR, I would suggest reporting it via e-mail.

  3. #3
    Member
    Join Date
    Jun 2015
    Location
    Switzerland
    Posts
    667
    Thanks
    204
    Thanked 241 Times in 146 Posts
    Quote Originally Posted by nemequ View Post
    Regardless, I don't think gipfeli's author hangs out here…
    We are here. I'll ask Rasto to take a look.

  4. #4
    Programmer
    Join Date
    May 2008
    Location
    PL
    Posts
    307
    Thanks
    68
    Thanked 166 Times in 63 Posts
    Quote Originally Posted by nemequ View Post
    Reporting issues may be off, but you can still file pull requests. This sounds like https://github.com/google/gipfeli/pull/4
    This is the same problem.

    The patch from jibsen works for me, but now I have decompression errors. I think that it may be a requirement of continuity of memory between prev_block and input_block or going outside a buffer during compression.

  5. #5
    Member
    Join Date
    Jul 2013
    Location
    United States
    Posts
    194
    Thanks
    44
    Thanked 140 Times in 69 Posts
    Quote Originally Posted by Jyrki Alakuijala View Post
    We are here. I'll ask Rasto to take a look.
    Nice, thanks. Are you involved in Gipfeli at all, or do you just know (work with?) him? I know you're both at Google, but it is a somewhat large company…

    Quote Originally Posted by inikep View Post
    The patch from jibsen works for me, but now I have decompression errors. I think that it may be a requirement of continuity of memory between prev_block and input_block or going outside a buffer during compression.
    FWIW Jørgen has another PR open against Gipfeli which *might* resolve that. I can't really tell from the description if those are the same issue, but I know he filed both of those PRs in an effort to get it working with Squash on Windows, so the odds are decent.

  6. #6
    Programmer
    Join Date
    May 2008
    Location
    PL
    Posts
    307
    Thanks
    68
    Thanked 166 Times in 63 Posts
    The second patch solves decompression errors: https://github.com/google/gipfeli/pull/5

Similar Threads

  1. gipfeli
    By m^2 in forum Data Compression
    Replies: 6
    Last Post: 30th June 2014, 18:07

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •